Skip to content

Use default ports for protocol when no explicit port provided in URL #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use default ports for protocol when no explicit port provided in URL #44

wants to merge 1 commit into from

Conversation

mrhwick
Copy link

@mrhwick mrhwick commented Apr 25, 2018

No description provided.

ljharb
ljharb requested changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need some tests.

More importantly, though, does node's url core module have this feature? If not, we can't add it.

@ljharb ljharb marked this pull request as draft January 27, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrhwick @ljharb